linux-kernel - Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Oct 2021 12:04:08 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to
 binding

On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote:

> On Mon, 04 Oct 2021, Bjorn Andersson wrote:
> 
> > Update the binding with eitght more SPMI PMIC compatibles found in the
> 
> Spell check.
> 

Bummer...

> > PMIC info list in the Qualcomm socinfo driver.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > index 5ef79bf3d035..1d2b5f067556 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > @@ -29,6 +29,8 @@ Required properties:
> >                     "qcom,pm8916",
> >                     "qcom,pm8004",
> >                     "qcom,pm8909",
> > +                   "qcom,pm8028",
> > +                   "qcom,pm8901",
> >                     "qcom,pm8950",
> >                     "qcom,pmi8950",
> >                     "qcom,pm8998",
> > @@ -38,6 +40,12 @@ Required properties:
> >                     "qcom,pmk8350",
> >                     "qcom,pm7325",
> >                     "qcom,pmr735a",
> > +                   "qcom,pm8150",
> > +                   "qcom,pm8150l",
> > +                   "qcom,pm8150b",
> > +                   "qcom,pmk8002",
> > +                   "qcom,pm8150c",
> > +                   "qcom,smb2351",
> >                     or generalized "qcom,spmi-pmic".
> >  - reg:             Specifies the SPMI USID slave address for this device.
> >                     For more information see:
> 
> Is there any reason why these can't be in lexicographical order?
> 

Definitely not, both this list and the list compatible list in the
driver would be better of sorted. I just didn't want to sort and add the
entries in a single commit.

Do you want me to respin this, adding two patches that sort the
elements? Or will you fix my awesome spelling of 8 above and I send you
the patches that shuffles the entries?

Thanks,
Bjorn

> -- 
> Lee Jones [?????????]
> Senior Technical Lead - Developer Services
> Linaro.org ??? Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog