linux-kernel - Re: [PATCH] usbip: tools: usbipd: fix duplicate option definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <178457ee-4f66-07fd-e7bd-cee353414810@linuxfoundation.org>
Date:   Wed, 13 Oct 2021 09:57:59 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Alyssa Ross <hi@...ssa.is>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     Dominik Paulus <dominik.paulus@....de>,
        "open list:USB OVER IP DRIVER" <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] usbip: tools: usbipd: fix duplicate option definition

On 10/13/21 8:57 AM, Alyssa Ross wrote:
> This seems to have been introduced by mistake in
> f49ad35cd124 ("staging: usbip: Fix IPv6 support in usbipd").
> 

Thanks for the patch.

Add a sentence or two to say what is being fixed and use Fixes tag
for the commit.

> Signed-off-by: Alyssa Ross <hi@...ssa.is>
> ---
>   tools/usb/usbip/src/usbipd.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
> index 48398a78e88a..33e8512de7c4 100644
> --- a/tools/usb/usbip/src/usbipd.c
> +++ b/tools/usb/usbip/src/usbipd.c
> @@ -589,7 +589,6 @@ int main(int argc, char *argv[])
>   		{ "ipv4",     no_argument,       NULL, '4' },
>   		{ "ipv6",     no_argument,       NULL, '6' },
>   		{ "daemon",   no_argument,       NULL, 'D' },
> -		{ "daemon",   no_argument,       NULL, 'D' },
>   		{ "debug",    no_argument,       NULL, 'd' },
>   		{ "device",   no_argument,       NULL, 'e' },
>   		{ "pid",      optional_argument, NULL, 'P' },
> 

thanks,
-- Shuah