linux-kernel - Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 19:30:49 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Saravana Kannan <saravanak@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h

On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > When adding some stuff to the header file we must not rely on
> > implicit dependencies that are happen by luck or bugs in other
> > headers. Hence fwnode.h needs to use bits.h directly.
> >
> > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> > Cc: Saravana Kannan <saravanak@...gle.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Acked-by: Saravana Kannan <saravanak@...gle.com>

I'm going to pick this up, thanks!

> > ---
> >  include/linux/fwnode.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> > index 9f4ad719bfe3..3a532ba66f6c 100644
> > --- a/include/linux/fwnode.h
> > +++ b/include/linux/fwnode.h
> > @@ -11,6 +11,7 @@
> >
> >  #include <linux/types.h>
> >  #include <linux/list.h>
> > +#include <linux/bits.h>
> >  #include <linux/err.h>
> >
> >  struct fwnode_operations;
> > --
> > 2.33.0
> >