linux-kernel - Re: [PATCH] acpi: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 20:04:10 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Qing Wang <wangqing@...o.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: replace snprintf in show functions with sysfs_emit

On Wed, Oct 13, 2021 at 5:25 AM Qing Wang <wangqing@...o.com> wrote:
>
> coccicheck complains about the use of snprintf() in sysfs show functions.
>
> Fix the coccicheck warning:
> WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@...o.com>
> ---
>  drivers/acpi/acpi_lpss.c | 2 +-
>  drivers/acpi/dock.c      | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 894b7e6..9c437d4 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -748,7 +748,7 @@ static ssize_t lpss_ltr_show(struct device *dev, struct device_attribute *attr,
>         if (ret)
>                 return ret;
>
> -       return snprintf(buf, PAGE_SIZE, "%08x\n", ltr_value);
> +       return sysfs_emit(buf, "%08x\n", ltr_value);
>  }
>
>  static ssize_t lpss_ltr_mode_show(struct device *dev,
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index 7cf9215..c8e9b96 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -492,7 +492,7 @@ static ssize_t docked_show(struct device *dev,
>         struct acpi_device *adev = NULL;
>
>         acpi_bus_get_device(dock_station->handle, &adev);
> -       return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev));
> +       return sysfs_emit(buf, "%u\n", acpi_device_enumerated(adev));
>  }
>  static DEVICE_ATTR_RO(docked);
>
> @@ -504,7 +504,7 @@ static ssize_t flags_show(struct device *dev,
>  {
>         struct dock_station *dock_station = dev->platform_data;
>
> -       return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);
> +       return sysfs_emit(buf, "%d\n", dock_station->flags);
>
>  }
>  static DEVICE_ATTR_RO(flags);
> @@ -543,7 +543,7 @@ static ssize_t uid_show(struct device *dev,
>         if (ACPI_FAILURE(status))
>                 return 0;
>
> -       return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
> +       return sysfs_emit(buf, "%llx\n", lbuf);
>  }
>  static DEVICE_ATTR_RO(uid);
>
> @@ -562,7 +562,7 @@ static ssize_t type_show(struct device *dev,
>         else
>                 type = "unknown";
>
> -       return snprintf(buf, PAGE_SIZE, "%s\n", type);
> +       return sysfs_emit(buf, "%s\n", type);
>  }
>  static DEVICE_ATTR_RO(type);
>
> --

Applied as 5.16 material with some edits in the subject and changelog, thanks!