linux-kernel - Re: [PATCH] RDMA/core: Set sgtable nents when using ib_dma_virt_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d32f9bc4-78a8-45ab-04e6-69aa6f1952e5@deltatee.com>
Date:   Wed, 13 Oct 2021 12:35:19 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Bart Van Assche <bvanassche@....org>, linux-rdma@...r.kernel.org,
        Jason Gunthorpe <jgg@...pe.ca>
Cc:     linux-kernel@...r.kernel.org, Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH] RDMA/core: Set sgtable nents when using
 ib_dma_virt_map_sg()




On 2021-10-13 12:33 p.m., Bart Van Assche wrote:
> On 10/13/21 9:59 AM, Logan Gunthorpe wrote:
>> ib_dma_map_sgtable_attrs() should be mapping the sgls and setting nents
>> but the ib_uses_virt_dma() path falls back to ib_dma_virt_map_sg()
>> which will not set the nents in the sgtable.
>>
>> Check the return value (per the map_sg calling convention) and set
>> sgt->nents appropriately on success.
>>
>> Link:
>> https://lore.kernel.org/all/996fa723-18ef-d35b-c565-c9cb9dc2d5e1@acm.org/T/#u
>>
>> Reported-by: Bart Van Assche <bvanassche@....org>
>> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
>> Tested-by: Bart Van Assche <bvanassche@....org>
> 
> Does this patch need a "Fixes:" tag?

Right, yeah:

Fixes: 79fbd3e1241c ("RDMA: Use the sg_table directly and remove the
opencoded version from umem")

Logan