linux-kernel - Re: [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163415386095.936959.16722730558107515093@swboyd.mtv.corp.google.com>
Date:   Wed, 13 Oct 2021 12:37:40 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Fenglin Wu <quic_fenglinw@...cinc.com>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     collinsd@...eaurora.org, subbaram@...eaurora.org,
        Yimin Peng <yiminp@...eaurora.org>, tglx@...utronix.de,
        maz@...nel.org
Subject: Re: [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags

Quoting Fenglin Wu (2021-10-12 23:27:22)
> copy IRQCHIP driver maintainers as requested in another patch.
> 
> On 10/13/2021 1:42 AM, Stephen Boyd wrote:
> > Quoting Fenglin Wu (2021-09-16 23:33:02)
> >> From: Yimin Peng <yiminp@...eaurora.org>
> >>
> >> Have the qpnpint_irq_set_type function clear unwanted high/low
> >> trigger bits when updating the interrupt flags.
> > Why?
> There was a requirement to update the PMIC module interrupt type 
> dynamically
> (such as from low level trigger to high level trigger), hence it's required
> to clear the unnecessary trigger type when setting it.

Can you clearly describe the problem in the commit text? Is this a bug
fix?

> >> Signed-off-by: Yimin Peng <yiminp@...eaurora.org>
> >> Signed-off-by: Subbaraman Narayanamurthy <subbaram@...eaurora.org>
> >> Signed-off-by: Fenglin Wu <quic_fenglinw@...cinc.com>
> >> ---
> > Does this need a Fixes tag?
> Maybe no need to a Fixes tag because this is part of the initial code when
> interrupt handling is added?

Was it always broken? Or trigger types haven't been changing at runtime
because most users are requesting irqs and forgetting about it? Are you
using gpio-keys or something like that now? Adding a Fixes tag doesn't
hurt.