linux-kernel - RE: [EXTERNAL] Re: [PATCH v2 1/2] PCI: hv: Make the code arch neutral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN8PR21MB1140F178549EA2267F3F134DC0B79@BN8PR21MB1140.namprd21.prod.outlook.com>
Date:   Wed, 13 Oct 2021 19:44:52 +0000
From:   Sunil Muthuswamy <sunilmut@...rosoft.com>
To:     Boqun Feng <boqun.feng@...il.com>
CC:     Marc Zyngier <maz@...nel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Boqun Feng <Boqun.Feng@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof Wilczyński" <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Wei Liu <wei.liu@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "\"H. Peter Anvin\"" <hpa@...or.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Baihua Lu <Baihua.Lu@...rosoft.com>
Subject: RE: [EXTERNAL] Re: [PATCH v2 1/2] PCI: hv: Make the code arch neutral

On Tuesday, October 12, 2021 11:06 PM,
Boqun Feng <boqun.feng@...il.com> wrote:

> As reported by Baihua (I can also reproduce), compile errors are hit
> when compiling with CONFIG_PCI_HYPERV=m:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pci-
> hyperv-irqchip.o
> ERROR: modpost: "hv_msi_prepare" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_pci_irqchip_init" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_pci_irqchip_free" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_msi_get_int_vector" [drivers/pci/controller/pci-
> hyperv.ko] undefined!
> ERROR: modpost: "hv_set_msi_entry_from_desc" [drivers/pci/controller/pci-
> hyperv.ko] undefined!
> 
> It means that we MODULE_LICENSE() should be added in
> pci-hyperv-irqchip.c, also these symbols should be exported.
> 
Thanks for catching this. Will fix in v3.

- Sunil