linux-kernel - Re: [PATCH] spi: cadence-quadspi: fix dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 20:59:45 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Yoshitaka Ikeda <ikeda@...int.co.jp>,
        Apurva Nandan <a-nandan@...com>,
        Pratyush Yadav <p.yadav@...com>, linux-kernel@...r.kernel.org,
        Ramuthevar Vadivel Murugan 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
Subject: Re: [PATCH] spi: cadence-quadspi: fix dma_unmap_single() call

On Wed, 13 Oct 2021 16:45:55 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> There are separate constants for the dma-mapping API and the dmaengine
> API, mixing them up causes a warning in some builds:
> 
> In file included from drivers/spi/spi-cadence-quadspi.c:12:
> drivers/spi/spi-cadence-quadspi.c: In function 'cqspi_versal_indirect_read_dma':
> drivers/spi/spi-cadence-quadspi.c:950:55: error: implicit conversion from 'enum dma_transfer_direction' to 'enum dma_data_direction' [-Werror=enum-conversion]
>   950 |         dma_unmap_single(dev, dma_addr, bytes_to_dma, DMA_DEV_TO_MEM);
>       |                                                       ^~~~~~~~~~~~~~
> include/linux/dma-mapping.h:407:70: note: in definition of macro 'dma_unmap_single'
>   407 | #define dma_unmap_single(d, a, s, r) dma_unmap_single_attrs(d, a, s, r, 0)
>       |                                                                      ^
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cadence-quadspi: fix dma_unmap_single() call
      commit: d9c55c95a3eac8536fbc6ef39dee69d3716aeee2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark