linux-kernel - Re: [PATCH] cpuidle: tegra: add ARCH_SUSPEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b4c1c31-3ef6-db9b-dc98-8a6f7a3d6243@gmail.com>
Date:   Wed, 13 Oct 2021 23:49:04 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thierry Reding <treding@...dia.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        He Ying <heying24@...wei.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency

13.10.2021 19:01, Arnd Bergmann пишет:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Some StrongARM processors don't support suspend, which leads
> to a build failure with the tegra cpuidle driver:
> 
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
>   Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
>   Selected by [y]:
>   - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
> 
> arch/arm/kernel/sleep.o: in function `__cpu_suspend':
> (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
> 
> Add an explicit dependency to make randconfig builds avoid
> this combination.
> 
> Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/cpuidle/Kconfig.arm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 2cc3c208a180..af97992eaa82 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE
>  config ARM_TEGRA_CPUIDLE
>  	bool "CPU Idle Driver for NVIDIA Tegra SoCs"
>  	depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
> +	depends on ARCH_SUSPEND_POSSIBLE
>  	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>  	select ARM_CPU_SUSPEND
>  	help
> 

Arnd, thank you for the patch!

Apparently ARM_QCOM_SPM_CPUIDLE doesn't have that problem visible
because it selects QCOM_SPM, which depends on ARCH_QCOM, and thus
ARCH_QCOM should be auto-selected(?). I'm curious whether this needs to
be corrected, otherwise (ARCH_QCOM || COMPILE_TEST) doesn't make much
sense for that driver. And then it will need the same Kconfig fix as well.

I assume this problem wasn't caught by regular kernel build bots because
they don't test randconfig, don't they?