lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 13 Oct 2021 23:07:32 +0200
From:   Borislav Petkov <>
To:     Thomas Gleixner <>
Cc:     Kuppuswamy Sathyanarayanan 
        Ingo Molnar <>,,
        Paolo Bonzini <>,
        David Hildenbrand <>,
        Andrea Arcangeli <>,
        Josh Poimboeuf <>,
        Juergen Gross <>, Deep Shah <>,
        VMware Inc <>,
        Vitaly Kuznetsov <>,
        Wanpeng Li <>,
        Jim Mattson <>,
        Joerg Roedel <>, Peter H Anvin <>,
        Dave Hansen <>,
        Tony Luck <>,
        Dan Williams <>,
        Andi Kleen <>,
        Kirill Shutemov <>,
        Sean Christopherson <>,
        Kuppuswamy Sathyanarayanan <>,
Subject: Re: [PATCH v10 03/11] x86/cpufeatures: Add TDX Guest CPU feature

On Wed, Oct 13, 2021 at 10:44:37PM +0200, Thomas Gleixner wrote:
> No. This is tasteless garbage, really.
> tdx_early_init() is invoked from x86_64_start_kernel() very early in the
> boot process __before__ is_tdx_guest() is invoked.
> So why on earth is it requried to keep those conditionals and cpuid()
> muck around after init?

Yah, reportedly, they wanna parse cmdline options so it has to be after
copy_bootdata() but copy_bootdata() has a cc_platform_has() call which
ends up in is_tdx_guest() on Intel and there you have the catch 22
because CPUID hasn't happened yet in tdx_early_init().


Powered by blists - more mailing lists