linux-kernel - Re: [mcgrof:modules-next 1/1] include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'Elf32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a482ade-7e73-ba6f-457e-75dfdb80a2c8@linuxfoundation.org>
Date:   Wed, 13 Oct 2021 16:16:36 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [mcgrof:modules-next 1/1] include/linux/kern_levels.h:5:18:
 warning: format '%llu' expects argument of type 'long long unsigned int', but
 argument 3 has type 'Elf32_Off' {aka 'unsigned int'}

On 10/13/21 3:18 PM, Luis Chamberlain wrote:
> On Wed, Oct 13, 2021 at 11:09:15AM -0600, Shuah Khan wrote:
>> Hi Luis,
>> We can introduce arch specific header print routine. Easy option is not
>> printing any info., which we know isn't very useful.
>>
>> Let me know your thoughts.
> 
> You found an issue without the debug prints, and so you'd know better if
> the effort is worth the trouble, so I'll let you decide.
> 

Right the issue with validate_section_offset() is separate from the debug.
I will fix the pr_err warns first by tweaking the messages to not print
the variables that cause problems.

I will send a separate patch for validate_section_offset() which needs to
be arch specific similar to elf_check_arch().

Let me know if this plan sounds good.

thanks,
-- Shuah