linux-kernel - Re: [PATCH] init: Make unknown command line param message clearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211013161259.39e88182200b7a582c0cf632@linux-foundation.org>
Date:   Wed, 13 Oct 2021 16:12:59 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andrew Halaney <ahalaney@...hat.com>
Cc:     rostedt@...dmis.org, bp@...e.de, rdunlap@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer

On Wed, 13 Oct 2021 17:35:02 -0500 Andrew Halaney <ahalaney@...hat.com> wrote:

> The prior message is confusing users, which is the exact opposite of the
> goal. If the message is being seen, one of the following situations is
> happening:
> 
>  1. the param is misspelled
>  2. the param is not valid due to the kernel configuration
>  3. the param is intended for init but isn't after the '--'
>     delineator on the command line
> 
> To make that more clear to the user, explicitly mention "kernel command
> line" and also note that the params are still passed to user space to
> avoid causing any alarm over params intended for init.
> 
> Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
> Suggested-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Thanks.

BTW, I'm still sitting on your "init/main.c: silence some
-Wunused-parameter warnings", awaiting a response to Rasmus's
suggestion:
https://lkml.kernel.org/r/f06b8308-645b-031b-f9c6-b92400a269aa@rasmusvillemoes.dk