linux-kernel - Re: [PATCH v2 0/2] tracing: Fix removal of eprobes and add test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 08:16:05 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tom Zanussi <zanussi@...nel.org>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>,
        Yordan Karadzhov <y.karadz@...il.com>
Subject: Re: [PATCH v2 0/2] tracing: Fix removal of eprobes and add test

On Wed, 13 Oct 2021 16:51:11 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> When doing the following:
> 
>  # echo 'e:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
> 
>  # echo '-:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
> 
> It errors out with -ENOENT. This is because the "match" function does not
> take into account the "timer/hrtimer_cancel" part. Fix it and also make it
> work more genericly like kprobes and uprobes.

Thanks for update. This series looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
for the series.

Thank you!

> 
> v1 at: https://lore.kernel.org/all/20211013234206.37dd18ffcc2a2cbf4493f125@kernel.org/
> 
> Changes since v1:
>  - Instead of just fixing the missing system/event, have it be more like
>    kprobes and uprobes.
> 
> Steven Rostedt (VMware) (2):
>       tracing: Fix event probe removal from dynamic events
>       selftests/ftrace: Update test for more eprobe removal process
> 
> ----
>  kernel/trace/trace_eprobe.c                        | 54 ++++++++++++++++++++--
>  .../ftrace/test.d/dynevent/add_remove_eprobe.tc    | 54 +++++++++++++++++++++-
>  2 files changed, 103 insertions(+), 5 deletions(-)


-- 
Masami Hiramatsu <mhiramat@...nel.org>