linux-kernel - Re: [PATCH net-next 2/2] net: phy: dp83867: add generic PHY loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211013034832.GA3256@linux.intel.com>
Date:   Wed, 13 Oct 2021 11:48:32 +0800
From:   Wong Vee Khee <vee.khee.wong@...ux.intel.com>
To:     Ong Boon Leong <boon.leong.ong@...el.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: dp83867: add generic PHY loopback

On Wed, Oct 13, 2021 at 11:41:28AM +0800, Ong Boon Leong wrote:
> From: "Lay, Kuan Loon" <kuan.loon.lay@...el.com>
> 
> TI DP83867 supports loopback enabled using BMCR, so we add
> genphy_loopback to the phy driver.
> 
> Tested-by: Clement <clement@...el.com>
> Signed-off-by: Lay, Kuan Loon <kuan.loon.lay@...el.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com>
> ---
>  drivers/net/phy/dp83867.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index bb4369b75179..af47c62d6e04 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -878,6 +878,7 @@ static struct phy_driver dp83867_driver[] = {
>  
>  		.suspend	= genphy_suspend,
>  		.resume		= genphy_resume,
> +		.set_loopback	= genphy_loopback,

Isn't this already handled in phy_loopback() in 
drivers/net/phy/phy_device.c?

>  	},
>  };
>  module_phy_driver(dp83867_driver);