linux-kernel - Re: [PATCH] iio: imx8qxp-adc: Fix the error - defined but not used for runtime pm API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41381e8c-78f2-67ee-5ed0-dcf176f65da1@infradead.org>
Date:   Tue, 12 Oct 2021 21:31:07 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Cai Huoqing <caihuoqing@...du.com>, jic23@...nel.org,
        lars@...afoo.de, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com
Cc:     linux-imx@....com, linux-iio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imx8qxp-adc: Fix the error - defined but not used
 for runtime pm API

On 10/12/21 6:46 PM, Cai Huoqing wrote:
> Add the prefix '__maybe_unused' to imx8qxp_adc_runtime_suspend/resume()
> to avoid the compiler complain without setting CONFIG_SUSPEND,
> CONFIG_HIBERNATION and CONFIG_PM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>   drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
> index 5030e0d8318d..011bef4b5dda 100644
> --- a/drivers/iio/adc/imx8qxp-adc.c
> +++ b/drivers/iio/adc/imx8qxp-adc.c
> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
> +static int __maybe_unused imx8qxp_adc_runtime_suspend(struct device *dev)
>   {
>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int imx8qxp_adc_runtime_resume(struct device *dev)
> +static int __maybe_unused imx8qxp_adc_runtime_resume(struct device *dev)
>   {
>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> 


-- 
~Randy