linux-kernel - 回复: [PATCH] bcache: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <SL2PR06MB3082B818199080975B93D0B6BDB79@SL2PR06MB3082.apcprd06.prod.outlook.com>
Date:   Wed, 13 Oct 2021 07:39:15 +0000
From:   王擎 <wangqing@...o.com>
To:     Coly Li <colyli@...e.de>
CC:     "linux-bcache@...r.kernel.org" <linux-bcache@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH] bcache: replace snprintf in show functions with sysfs_emit


>>
>> diff --git a/drivers/md/bcache/sysfs.h b/drivers/md/bcache/sysfs.h
>> index 215df32..8bec32d 100644
>> --- a/drivers/md/bcache/sysfs.h
>> +++ b/drivers/md/bcache/sysfs.h
>> @@ -51,7 +51,7 @@ STORE(fn)                                                           \
>>   #define sysfs_printf(file, fmt, ...)                                        \
>>   do {                                                                        \
>>        if (attr == &sysfs_ ## file)                                    \
>> -             return snprintf(buf, PAGE_SIZE, fmt "\n", __VA_ARGS__); \
>> +             return sysfs_emit(buf, fmt "\n", __VA_ARGS__);  \
>>   } while (0)
>>   
>>   #define sysfs_print(file, var)                                              \
> 
> IMHO I like this change :-) BTW, for snprint() from util.h, it seems 
> only to be used by sysfs_print() in syfs.h, would you like to change it 
> to use sysfs_emit too ?
> 
> Thanks for the patch.
> 
> Coly Li
> 

sysfs_print() should also be modified if size is a fixed value PAGE_SIZE, 
but here is param, it would be appreciate if you have better method.

Thanks,

Qing