linux-kernel - Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96c810cb-f7e3-d9ff-9713-7ec007ebb599@microchip.com>
Date:   Wed, 13 Oct 2021 08:15:46 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>
CC:     <geert@...ux-m68k.org>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC

On 03.10.2021 06:03, Randy Dunlap wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
> 
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
> 
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: alsa-devel@...a-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---
>   sound/soc/atmel/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
> 
>   config SND_ATMEL_SOC_PDC
>          bool
> +       depends on HAS_DMA || COMPILE_TEST

SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand 
the need for this...