linux-kernel - Re: [tip:sched/core 45/47] kernel/sched/topology.c:23:20: error: unused function 'sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0538ccac-19eb-a184-6aef-1d11eefbae17@hisilicon.com>
Date:   Wed, 13 Oct 2021 17:02:42 +0800
From:   Yicong Yang <yangyicong@...ilicon.com>
To:     kernel test robot <lkp@...el.com>
CC:     <yangyicong@...ilicon.com>, <llvm@...ts.linux.dev>,
        <kbuild-all@...ts.01.org>, <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>, Barry Song <baohua@...nel.org>,
        Valentin Schneider <valentin.schneider@....com>
Subject: Re: [tip:sched/core 45/47] kernel/sched/topology.c:23:20: error:
 unused function 'sched_debug'

Hi,

On 2021/10/13 2:30, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> head:   b2d5b9cec60fecc72a13191c2c6c05acf60975a5
> commit: f43df9225fcad9b07a4ef4d0fe4c3ad2fb4ce82d [45/47] sched/topology: Remove unused numa_distance in cpu_attach_domain()
> config: hexagon-buildonly-randconfig-r004-20211012 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c3dcf39554dbea780d6cb7e12239451ba47a2668)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=f43df9225fcad9b07a4ef4d0fe4c3ad2fb4ce82d
>         git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>         git fetch --no-tags tip sched/core
>         git checkout f43df9225fcad9b07a4ef4d0fe4c3ad2fb4ce82d
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> kernel/sched/topology.c:23:20: error: unused function 'sched_debug' [-Werror,-Wunused-function]
>    static inline bool sched_debug(void)
>                       ^
>    1 error generated.
> 

sched_debug() is unused if CONFIG_ENERGY_MODEL=n || CONFIG_CPU_FREQ_GOV_SCHEDUTIL=n and CONFIG_NUMA=n,
which is the case in the report. This is not introduced by this patch.

A __maybe_unused qualify for sched_debug() may fix this. Not sure we intends to do so.

> 
> vim +/sched_debug +23 kernel/sched/topology.c
> 
> f2cb13609d5397 Ingo Molnar    2017-02-01  22  
> f2cb13609d5397 Ingo Molnar    2017-02-01 @23  static inline bool sched_debug(void)
> f2cb13609d5397 Ingo Molnar    2017-02-01  24  {
> 9406415f46f612 Peter Zijlstra 2021-04-15  25  	return sched_debug_verbose;
> f2cb13609d5397 Ingo Molnar    2017-02-01  26  }
> f2cb13609d5397 Ingo Molnar    2017-02-01  27  
> 
> :::::: The code at line 23 was first introduced by commit
> :::::: f2cb13609d5397cdd747f3ed6fb651233851717d sched/topology: Split out scheduler topology code from core.c into topology.c
> 
> :::::: TO: Ingo Molnar <mingo@...nel.org>
> :::::: CC: Ingo Molnar <mingo@...nel.org>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>