linux-kernel - Re: Use of '%#02x' is almost always wrong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 13:39:05 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: Use of '%#02x' is almost always wrong

On Wed, Oct 13, 2021 at 01:17:30AM -0700, Joe Perches wrote:
> On Wed, 2021-10-13 at 09:15 +0300, Dan Carpenter wrote:
> > On Sun, Oct 10, 2021 at 09:45:30AM -0700, Joe Perches wrote:
> > > Perhaps too many developers do not know that using '%#<width>x'
> > > in printf output _includes_ the 0x prefix in the output width.
> > > 
> > 
> > This is a good point.  Presumably you're going to add it to checkpatch.pl?
> 
> Yeah.  Something like the below:
> 

Awesome!  Thanks!

regards,
dan carpenter