linux-kernel - Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211013105856.yve6n5zu625im5fo@pengutronix.de>
Date:   Wed, 13 Oct 2021 12:58:56 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-pci@...r.kernel.org, Alexander Duyck <alexanderduyck@...com>,
        Russell Currey <ruscur@...sell.cc>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        oss-drivers@...igine.com, netdev@...r.kernel.org,
        Oliver O'Halloran <oohall@...il.com>,
        "H. Peter Anvin" <hpa@...or.com>, Jiri Olsa <jolsa@...hat.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Paul Mackerras <paulus@...ba.org>,
        Marco Chiappero <marco.chiappero@...el.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-scsi@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
        Ido Schimmel <idosch@...dia.com>, x86@...nel.org,
        qat-linux@...el.com, Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Rafał Miłecki <zajec5@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Fiona Trahe <fiona.trahe@...el.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jack Xu <jack.xu@...el.com>, Borislav Petkov <bp@...en8.de>,
        Michael Buesch <m@...s.ch>, Jiri Pirko <jiri@...dia.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Juergen Gross <jgross@...e.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        xen-devel@...ts.xenproject.org, Vadym Kochan <vkochan@...vell.com>,
        MPT-FusionLinux.pdl@...adcom.com, linux-usb@...r.kernel.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        linux-crypto@...r.kernel.org, kernel@...gutronix.de,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Simon Horman <simon.horman@...igine.com>,
        Wojciech Ziemba <wojciech.ziemba@...el.com>,
        Tomaszx Kowalik <tomaszx.kowalik@...el.com>,
        linuxppc-dev@...ts.ozlabs.org,
        Taras Chornyi <tchornyi@...vell.com>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver

Hello,

On Wed, Oct 13, 2021 at 05:54:28AM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-König wrote:
> > On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> > > index d997c9c3ebb5..7eb3706cf42d 100644
> > > --- a/drivers/misc/cxl/guest.c
> > > +++ b/drivers/misc/cxl/guest.c
> > > @@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *afu,
> > >  				pci_channel_state_t state)
> > >  {
> > >  	struct pci_dev *afu_dev;
> > > +	struct pci_driver *afu_drv;
> > > +	struct pci_error_handlers *err_handler;
> > 
> > These two could be moved into the for loop (where afu_drv was with my
> > patch already). This is also possible in a few other drivers.
> 
> That's true, they could.  I tried to follow the prevailing style in
> the file.  At least in cxl, I didn't see any other cases of
> declarations being in the minimal scope like that.

I don't care much, do whatever you consider nice. I'm happy you liked
the cleanup and that you took it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)