linux-kernel - Re: [net-next PATCH v6 05/16] net: dsa: qca8k: add support for cpu port 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 13:42:59 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Russell King <linux@...linux.org.uk>,
        John Crispin <john@...ozen.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [net-next PATCH v6 05/16] net: dsa: qca8k: add support for cpu
 port 6

On Wed, Oct 13, 2021 at 12:10:04PM +0800, DENG Qingfang wrote:
> On Wed, Oct 13, 2021 at 03:16:11AM +0200, Ansuel Smith wrote:
> > @@ -1017,13 +1033,14 @@ static int
> >  qca8k_setup(struct dsa_switch *ds)
> >  {
> >  	struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
> > +	u8 cpu_port;
> >  	int ret, i;
> >  	u32 mask;
> >  
> > -	/* Make sure that port 0 is the cpu port */
> > -	if (!dsa_is_cpu_port(ds, 0)) {
> > -		dev_err(priv->dev, "port 0 is not the CPU port");
> > -		return -EINVAL;
> > +	cpu_port = qca8k_find_cpu_port(ds);
> > +	if (cpu_port < 0) {
> 
> cpu_port should be of type int, otherwise this is always false.
>

Sorry for ignoring the prev review. Now I see what you mean and you are
totally right!

> > +		dev_err(priv->dev, "No cpu port configured in both cpu port0 and port6");
> > +		return cpu_port;
> >  	}

-- 
	Ansuel