lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20211013082025-mutt-send-email-mst@kernel.org> Date: Wed, 13 Oct 2021 08:21:26 -0400 From: "Michael S. Tsirkin" <mst@...hat.com> To: Christoph Hellwig <hch@....de> Cc: Xie Yongji <xieyongji@...edance.com>, jasowang@...hat.com, stefanha@...hat.com, virtualization@...ts.linux-foundation.org, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, Kevin Wolf <kwolf@...hat.com>, Jens Axboe <axboe@...nel.dk> Subject: Re: [PATCH v5] virtio-blk: Add validation for block size in config space On Mon, Oct 11, 2021 at 01:40:41PM +0200, Christoph Hellwig wrote: > On Tue, Oct 05, 2021 at 06:42:43AM -0400, Michael S. Tsirkin wrote: > > Stefan also pointed out this duplicates the logic from > > > > if (blksize < 512 || blksize > PAGE_SIZE || !is_power_of_2(blksize)) > > return -EINVAL; > > > > > > and a bunch of other places. > > > > > > Would it be acceptable for blk layer to validate the input > > instead of having each driver do it's own thing? > > Maybe inside blk_queue_logical_block_size? > > I'm pretty sure we want down that before. Let's just add a helper > just for that check for now as part of this series. Actually validating > in in blk_queue_logical_block_size seems like a good idea, but returning > errors from that has a long tail. Xie Yongji, I think I will revert this patch for now - can you please work out adding that helper and using it in virtio? Thanks, -- MST
Powered by blists - more mailing lists