linux-kernel - Re: [PATCH v3] PCI: uniphier: Serialize INTx masking/unmasking and fix the bit operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163413129990.22138.15702601418817174711.b4-ty@arm.com>
Date:   Wed, 13 Oct 2021 14:21:57 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Rob Herring <robh@...nel.org>,
        Pali Rohár <pali@...nel.org>,
        Marc Zyngier <maz@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Krzysztof Wilczyński <kw@...ux.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH v3] PCI: uniphier: Serialize INTx masking/unmasking and fix the bit operation

On Sat, 18 Sep 2021 09:22:59 +0900, Kunihiko Hayashi wrote:
> The condition register PCI_RCV_INTX is used in irq_mask() and irq_unmask()
> callbacks. Accesses to register can occur at the same time without a lock.
> Add a lock into each callback to prevent the issue.
> 
> And INTX mask and unmask fields in PCL_RCV_INTX register should only be
> set/reset for each bit. Clearing by PCL_RCV_INTX_ALL_MASK should be
> removed.
> 
> [...]

Applied to pci/qcom, thanks!

[1/1] PCI: uniphier: Serialize INTx masking/unmasking and fix the bit operation
      https://git.kernel.org/lpieralisi/pci/c/bab406fc11

Thanks,
Lorenzo