linux-kernel - Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211013141629.qfeqwsyi5yobzjca@gilmour>
Date:   Wed, 13 Oct 2021 16:16:29 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Rob Clark <robdclark@...il.com>,
        Caleb Connolly <caleb.connolly@...aro.org>
Cc:     Amit Pundir <amit.pundir@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Sean Paul <sean@...rly.run>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <freedreno@...ts.freedesktop.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Xinliang Liu <xinliang.liu@...aro.org>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Tian Tao <tiantao6@...ilicon.com>,
        Inki Dae <inki.dae@...sung.com>,
        Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Chen Feng <puck.chen@...ilicon.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>
Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order
 consistent

Hi Caleb,

On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote:
> Hi,
> 
> On 30/09/2021 20:49, Amit Pundir wrote:
> > On Thu, 30 Sept 2021 at 04:50, Rob Clark <robdclark@...il.com> wrote:
> > > 
> > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz <john.stultz@...aro.org> wrote:
> > > > 
> > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz <john.stultz@...aro.org> wrote:
> > > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz <john.stultz@...aro.org> wrote:
> > > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard <maxime@...no.tech> wrote:
> > > > > > > The best practice to avoid those issues is to register its functions only after
> > > > > > > all its dependencies are live. We also shouldn't wait any longer than we should
> > > > > > > to play nice with the other components that are waiting for us, so in our case
> > > > > > > that would mean moving the DSI device registration to the bridge probe.
> > > > > > > 
> > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm
> > > > > > > would be affected by this and wouldn't probe anymore after those changes.
> > > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still
> > > > > > > requires to be tested), but the changes in msm seemed to be far more important
> > > > > > > and I wasn't confortable doing them.
> > > > > > 
> > > > > > 
> > > > > > Hey Maxime,
> > > > > >    Sorry for taking so long to get to this, but now that plumbers is
> > > > > > over I've had a chance to check it out on kirin
> > > > > > 
> > > > > > Rob Clark pointed me to his branch with some fixups here:
> > > > > >     https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework
> > > > > > 
> > > > > > But trying to boot hikey with that, I see the following loop indefinitely:
> > > > > > [    4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator
> > > > > > [    4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator
> > > > > > [    4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator
> > > > > > [    4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator
> > > > > > [    4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator
> > > > > > [    4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator
> > > > > > [    4.681898] adv7511 2-0039: failed to find dsi host
> > > > > 
> > > > > I just realized Rob's tree is missing the kirin patch. My apologies!
> > > > > I'll retest and let you know.
> > > > 
> > > > Ok, just retested including the kirin patch and unfortunately I'm
> > > > still seeing the same thing.  :(
> > > > 
> > > > Will dig a bit and let you know when I find more.
> > > 
> > > Did you have a chance to test it on anything using drm/msm with DSI
> > > panels?  That would at least confirm that I didn't miss anything in
> > > the drm/msm patch to swap the dsi-host vs bridge ordering..
> > 
> > Hi, smoke tested
> > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework
> > on Pocophone F1 (sdm845 / A630) with v5.15-rc3. I see no obvious
> > regressions in my limited testing so far including video (youtube)
> > playback.
> Tested on the OnePlus 6 too booting AOSP, works fine. This *fixes*
> FBDEV_EMULATION (so we can get a working framebuffer console) which was
> otherwise broken on 5.15.
> 
> However it spits out some warnings during boot: https://p.calebs.dev/gucysowyna.yaml

Thanks for testing. It looks like the runtime_pm ordering between the
msm devices changed a bit with the conversion Rob did.

Rob, do you know what could be going on?

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)