linux-kernel - Re: [PATCH][next] PCI: apple: Remove redundant initialization of pointer port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7fb08233-efc9-b0bd-b234-084e52878036@canonical.com>
Date:   Wed, 13 Oct 2021 15:22:22 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Marc Zyngier <maz@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] PCI: apple: Remove redundant initialization of
 pointer port_pdev

On 13/10/2021 14:41, Lorenzo Pieralisi wrote:
> On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The pointer port_pdev is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>   drivers/pci/controller/pcie-apple.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Squashed into the commit it is fixing.
> 

Thanks. Much appreciated.

> Thanks !
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
>> index b4db7a065553..19fd2d38aaab 100644
>> --- a/drivers/pci/controller/pcie-apple.c
>> +++ b/drivers/pci/controller/pcie-apple.c
>> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>>   {
>>   	struct pci_config_window *cfg = pdev->sysdata;
>>   	struct apple_pcie *pcie = cfg->priv;
>> -	struct pci_dev *port_pdev = pdev;
>> +	struct pci_dev *port_pdev;
>>   	struct apple_pcie_port *port;
>>   
>>   	/* Find the root port this device is on */
>> -- 
>> 2.32.0
>>