linux-kernel - Re: [PATCH v2 2/2] mailbox: mtk-cmdq: Fix local clock ID usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YWhS1qkwqkmwAyi8@google.com>
Date:   Thu, 14 Oct 2021 23:55:02 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Fei Shao <fshao@...omium.org>
Cc:     Jassi Brar <jaswinder.singh@...aro.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "jason-jh.lin" <jason-jh.lin@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] mailbox: mtk-cmdq: Fix local clock ID usage

On Thu, Oct 14, 2021 at 08:03:52PM +0800, Fei Shao wrote:
> In the probe function, the clock IDs were pointed to local variables
> which should only be used in the same code block, and any access to them
> after the probing stage becomes an use-after-free case.
> 
> Since there are only limited variants of the gce clock names so far, we
> can just declare them as static constants to fix the issue.
> 
> Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for
> mt8195")
> Signed-off-by: Fei Shao <fshao@...omium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@...gle.com>