linux-kernel - Re: [PATCH v2] tracing/cfi: Fix cmp_entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 09:23:53 -0700
From:   Kalesh Singh <kaleshsingh@...gle.com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Suren Baghdasaryan <surenb@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tracing/cfi: Fix cmp_entries_* functions signature mismatch

On Thu, Oct 14, 2021 at 4:13 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Kalesh,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on 348949d9a4440abdab3b1dc99a9bb660e8c7da7c]
>
> url:    https://github.com/0day-ci/linux/commits/Kalesh-Singh/tracing-cfi-Fix-cmp_entries_-functions-signature-mismatch/20211014-093824
> base:   348949d9a4440abdab3b1dc99a9bb660e8c7da7c
> config: arm64-randconfig-r005-20211014 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/aca9efb61e0559ff7abff8c8bce5e1a65a73ccce
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Kalesh-Singh/tracing-cfi-Fix-cmp_entries_-functions-signature-mismatch/20211014-093824
>         git checkout aca9efb61e0559ff7abff8c8bce5e1a65a73ccce
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
>    kernel/trace/tracing_map.c: In function 'cmp_entries_dup':
> >> kernel/trace/tracing_map.c:839:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      839 |         const struct tracing_map_sort_entry **pa = A;
>          |                                                    ^
>    kernel/trace/tracing_map.c:840:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      840 |         const struct tracing_map_sort_entry **pb = B;
>          |                                                    ^
>    kernel/trace/tracing_map.c: In function 'cmp_entries_sum':
>    kernel/trace/tracing_map.c:853:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      853 |         const struct tracing_map_sort_entry **pa = A;
>          |                                                    ^
>    kernel/trace/tracing_map.c:854:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      854 |         const struct tracing_map_sort_entry **pb = B;
>          |                                                    ^
>    kernel/trace/tracing_map.c: In function 'cmp_entries_key':
>    kernel/trace/tracing_map.c:884:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      884 |         const struct tracing_map_sort_entry **pa = A;
>          |                                                    ^
>    kernel/trace/tracing_map.c:885:52: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      885 |         const struct tracing_map_sort_entry **pb = B;
>          |                                                    ^
>

I posted a v3 to address these:
https://lore.kernel.org/r/20211014045217.3265162-1-kaleshsingh@google.com/

Thanks,
Kalesh
>
> vim +/const +839 kernel/trace/tracing_map.c
>
>    836
>    837  static int cmp_entries_dup(const void *A, const void *B)
>    838  {
>  > 839          const struct tracing_map_sort_entry **pa = A;
>    840          const struct tracing_map_sort_entry **pb = B;
>    841          const struct tracing_map_sort_entry *a = *pa;
>    842          const struct tracing_map_sort_entry *b = *pb;
>    843          int ret = 0;
>    844
>    845          if (memcmp(a->key, b->key, a->elt->map->key_size))
>    846                  ret = 1;
>    847
>    848          return ret;
>    849  }
>    850
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@...roid.com.