[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33b810b9-0b5a-c284-c571-a30add06267f@quicinc.com>
Date: Thu, 14 Oct 2021 11:17:53 +0800
From: Fenglin Wu <quic_fenglinw@...cinc.com>
To: Stephen Boyd <sboyd@...nel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: <collinsd@...eaurora.org>, <subbaram@...eaurora.org>,
Yimin Peng <yiminp@...eaurora.org>, <tglx@...utronix.de>,
<maz@...nel.org>
Subject: Re: [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt
type flags
On 10/14/2021 3:37 AM, Stephen Boyd wrote:
> Quoting Fenglin Wu (2021-10-12 23:27:22)
>> copy IRQCHIP driver maintainers as requested in another patch.
>>
>> On 10/13/2021 1:42 AM, Stephen Boyd wrote:
>>> Quoting Fenglin Wu (2021-09-16 23:33:02)
>>>> From: Yimin Peng <yiminp@...eaurora.org>
>>>>
>>>> Have the qpnpint_irq_set_type function clear unwanted high/low
>>>> trigger bits when updating the interrupt flags.
>>> Why?
>> There was a requirement to update the PMIC module interrupt type
>> dynamically
>> (such as from low level trigger to high level trigger), hence it's required
>> to clear the unnecessary trigger type when setting it.
> Can you clearly describe the problem in the commit text? Is this a bug
> fix?
sure, will do.
>>>> Signed-off-by: Yimin Peng <yiminp@...eaurora.org>
>>>> Signed-off-by: Subbaraman Narayanamurthy <subbaram@...eaurora.org>
>>>> Signed-off-by: Fenglin Wu <quic_fenglinw@...cinc.com>
>>>> ---
>>> Does this need a Fixes tag?
>> Maybe no need to a Fixes tag because this is part of the initial code when
>> interrupt handling is added?
> Was it always broken? Or trigger types haven't been changing at runtime
> because most users are requesting irqs and forgetting about it? Are you
> using gpio-keys or something like that now? Adding a Fixes tag doesn't
> hurt.
You are right, it was reported by someone when using a PMIC GPIO and update
the interrupt at runtime, I am not sure if it's gpio-keys but that can be a
realistic case.
I will add a Fixes tag for it.
Powered by blists - more mailing lists