linux-kernel - Re: [PATCH v2] pinctrl: renesas: r8a779[56]x: add MediaLB pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 22:26:58 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrey Gusakov <andrey.gusakov@...entembedded.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        LUU HOAI <hoai.luu.ub@...esas.com>
Subject: Re: [PATCH v2] pinctrl: renesas: r8a779[56]x: add MediaLB pins

Hi,

> 
> Obviously not only the mlb_3pin groups, but also the functions have to
> be moved to the automotive[] arrays ;-)
> 
> I'll fix these up while applying, so no need to resend.

Looking at error mail from build robot (cited below).

Looks like also must put definitions of mlb_3pin_groups[] / mlb_3pin_mux[] / mlb_3pin_pins[] under GEN3 
ifdefs.

What are the proper steps now - send a v3 of the original patch, or send a fix to what is in linux-next ?

Nikita


 > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
 > head:   8006b911c90a4ec09958447d24c8a4c3538f5723
 > commit: 23f87fe82c0341ff79807fb5f92a05a33ce1b055 [7355/7806] pinctrl: renesas: r8a779[56]x: Add 
MediaLB pins
 > config: sh-buildonly-randconfig-r002-20211014 (attached as .config)
 > compiler: sh4-linux-gcc (GCC) 11.2.0
 > reproduce (this is a W=1 build):
 >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
 >          chmod +x ~/bin/make.cross
 >          # 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=23f87fe82c0341ff79807fb5f92a05a33ce1b055
 >          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
 >          git fetch --no-tags linux-next master
 >          git checkout 23f87fe82c0341ff79807fb5f92a05a33ce1b055
 >          # save the attached .config to linux build tree
 >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh
 >
 > If you fix the issue, kindly add following tag as appropriate
 > Reported-by: kernel test robot <lkp@...el.com>
 >
 > All errors (new ones prefixed by >>):
 >
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:5030:27: error: 'mlb_3pin_groups' defined but not used 
[-Werror=unused-const-variable=]
 >      5030 | static const char * const mlb_3pin_groups[] = {
 >           |                           ^~~~~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:2616:27: error: 'mlb_3pin_mux' defined but not used 
[-Werror=unused-const-variable=]
 >      2616 | static const unsigned int mlb_3pin_mux[] = {
 >           |                           ^~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:2613:27: error: 'mlb_3pin_pins' defined but not used 
[-Werror=unused-const-variable=]
 >      2613 | static const unsigned int mlb_3pin_pins[] = {
 >           |                           ^~~~~~~~~~~~~
 >     cc1: all warnings being treated as errors
 > --
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:4807:27: error: 'mlb_3pin_groups' defined but not used 
[-Werror=unused-const-variable=]
 >      4807 | static const char * const mlb_3pin_groups[] = {
 >           |                           ^~~~~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:2460:27: error: 'mlb_3pin_mux' defined but not used 
[-Werror=unused-const-variable=]
 >      2460 | static const unsigned int mlb_3pin_mux[] = {
 >           |                           ^~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:2457:27: error: 'mlb_3pin_pins' defined but not used 
[-Werror=unused-const-variable=]
 >      2457 | static const unsigned int mlb_3pin_pins[] = {
 >           |                           ^~~~~~~~~~~~~
 >     cc1: all warnings being treated as errors
 >
 >
 > vim +/mlb_3pin_groups +5030 drivers/pinctrl/renesas/pfc-r8a77965.c
 >
 >    5029	
 >> 5030	static const char * const mlb_3pin_groups[] = {
 >    5031		"mlb_3pin",
 >    5032	};
 >    5033	
 >