linux-kernel - Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s>
Date:   Thu, 14 Oct 2021 12:42:42 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     boris.ostrovsky@...cle.com, jgross@...e.com,
        sstabellini@...nel.org, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()'
 calls

On Thu, 14 Oct 2021, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Stefano Stabellini <sstabellini@...nel.org>


> ---
>  drivers/xen/pvcalls-back.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index b47fd8435061..d6f945fd4147 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
>  		write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
>  	}
>  	sock_release(mappass->sock);
> -	flush_workqueue(mappass->wq);
>  	destroy_workqueue(mappass->wq);
>  	kfree(mappass);
>  
> -- 
> 2.30.2
>