linux-kernel - Re: [PATCH] module: fix elf_validity_check() warns seen on 32-bit platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5456bb23-a170-b0fd-d03f-8efcf7e4f02c@linuxfoundation.org>
Date:   Thu, 14 Oct 2021 13:57:44 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     jeyu@...nel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] module: fix elf_validity_check() warns seen on 32-bit
 platforms

On 10/14/21 1:51 PM, Luis Chamberlain wrote:
> On Thu, Oct 14, 2021 at 12:10:44PM -0600, Shuah Khan wrote:
>> Fix the following warnings introduced by
>>
>> commit: 8b1185a4427b ("module: change to print useful messages from elf_validity_check()")
>>
>> warning: format '%llu' expects argument of type 'long long unsigned int',
>> but argument 3 has type 'Elf32_Off' {aka 'unsigned int'}
>>
>> Fix it by tweaking messages to not print ELF64* fields.
>>
>> Fixes: 8b1185a4427b ("module: change to print useful messages from elf_validity_check()")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> 
> Actually can I trouble you just fold this in with your older patch, I can just
> drop your old patch and merge this one. No point in merging two patches
> if we can just have one.
> 

Yes. I can do that.

thanks,
-- Shuah