linux-kernel - Re: [BUG] [5.15] Compilation error in arch/x86/kvm/mmu/spte.h with clang-14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb1da4d3-9e3e-4604-2f30-30292f9d13aa@redhat.com>
Date:   Thu, 14 Oct 2021 22:50:45 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Jim Mattson <jmattson@...gle.com>, torvic9@...lbox.org,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "bp@...en8.de" <bp@...en8.de>
Subject: Re: [BUG] [5.15] Compilation error in arch/x86/kvm/mmu/spte.h with
 clang-14

On 14/10/21 21:06, Nick Desaulniers wrote:
>> If we want to fix this, my vote is for casting to an int and updating the comment
> 
> At the least, I think bitwise operations should only be performed on
> unsigned types.

This is not a bitwise operation, it's a non-short-circuiting boolean 
operation.  I'll apply Jim's suggestion.

Paolo