linux-kernel - Re: [PATCH] nvme: Cleanup per-namespace chardev deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211014060422.GA24897@lst.de>
Date:   Thu, 14 Oct 2021 08:04:22 +0200
From:   Christoph Hellwig <hch@....de>
To:     Adam Manzanares <a.manzanares@...sung.com>
Cc:     "yi.zhang@...hat.com" <yi.zhang@...hat.com>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Javier González <javier.gonz@...sung.com>,
        Minwoo Im <minwoo.im.dev@...il.com>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: Cleanup per-namespace chardev deletion

On Wed, Oct 13, 2021 at 03:04:19PM +0000, Adam Manzanares wrote:
> Decrease reference count of chardevice during char device deletion in order to
> fix a kmemleak. Add relese function for the device associated chardev and moved
> ida_simple_remove into the release function.
> 
> Fixes: 2637bae (nvme: introduce generic per-namespace chardev)
> Reported-by: Yi Zhang <yi.zhang@...hat.com>
> Suggested-by: Sagi Grimberg <sagi@...mberg.me>
> Signed-off-by: Adam Manzanares <a.manzanares@...sung.com>

This looks good, but the subject seems wrong.  This isn't a cleanup
but a fix.  I can fix up the subject when applying it.