lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Oct 2021 09:20:32 +0200 From: Christophe Leroy <christophe.leroy@...roup.eu> To: Kees Cook <keescook@...omium.org> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, Andrew Morton <akpm@...ux-foundation.org>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, Helge Deller <deller@....de>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-ia64@...r.kernel.org, linux-parisc@...r.kernel.org, linux-arch@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH v1 04/10] asm-generic: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR to define associated stubs Le 13/10/2021 à 09:00, Kees Cook a écrit : > On Mon, Oct 11, 2021 at 05:25:31PM +0200, Christophe Leroy wrote: >> Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR instead of 'dereference_function_descriptor' >> to know whether arch has function descriptors. >> >> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu> > > I'd mention the intentionally-empty #if/#else in the commit log, as I, > like Helge, mentally tripped over it in the review. :) > > Reviewed-by: Kees Cook <keescook@...omium.org> > Ok, I did it in v2. I also renamed it HAVE_FUNCTION_DESCRIPTORS because behind the fact that it has some functions to dereference function descriptor, the main fact is that they have and use function descriptors. Christophe
Powered by blists - more mailing lists