linux-kernel - Re: [PATCH 5/8] dt-bindings: mfd: add Maxim MAX77714 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88eeb15a-f5b5-0a6e-3d81-494a9c57c878@canonical.com>
Date:   Thu, 14 Oct 2021 09:38:11 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Luca Ceresoli <luca@...aceresoli.net>, linux-kernel@...r.kernel.org
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Chiwoong Byun <woong.byun@...sung.com>,
        Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 5/8] dt-bindings: mfd: add Maxim MAX77714 PMIC

On 13/10/2021 23:28, Luca Ceresoli wrote:
> Hi Krzysztof,
> 
> thanks for reviewing.
> 
> On 12/10/21 10:02, Krzysztof Kozlowski wrote:
>> On 11/10/2021 17:56, Luca Ceresoli wrote:
>>> Add bindings for the MAX77714 PMIC with GPIO, RTC and watchdog.
>>>
>>> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>>> ---
>>>  .../bindings/mfd/maxim,max77714.yaml          | 58 +++++++++++++++++++
>>>  MAINTAINERS                                   |  5 ++
>>>  2 files changed, 63 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77714.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml
>>> new file mode 100644
>>> index 000000000000..2b0ce3b9bc92
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml
>>> @@ -0,0 +1,58 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mfd/maxim,max77714.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: MAX77714 PMIC with GPIO, RTC and watchdog from Maxim Integrated.
>>> +
>>> +maintainers:
>>> +  - Luca Ceresoli <luca@...aceresoli.net>
>>> +
>>> +description: |
>>> +  MAX77714 is a Power Management IC with 4 buck regulators, 9
>>> +  low-dropout regulators, 8 GPIOs, RTC and watchdog.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: maxim,max77714
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  interrupt-controller: true
>>> +
>>> +  "#interrupt-cells":
>>> +    const: 2
>>> +    description:
>>> +      The first cell is the IRQ number, the second cell is the trigger type.
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>> +  - interrupt-controller
>>> +  - "#interrupt-cells"
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/interrupt-controller/irq.h>
>>> +    i2c {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        pmic@1c {
>>> +            compatible = "maxim,max77714";
>>> +            reg = <0x1c>;
>>> +            interrupt-parent = <&gpio2>;
>>> +            interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>>> +
>>> +            interrupt-controller;
>>> +            #interrupt-cells = <2>;
>>> +        };
>>> +    };
>>
>> Looks good to me, but what about regulators and other properties? Are
>> you planning to add them later?
> 
> No plan to add them, sorry.
> 
> I know, complete bindings are better than incomplete bindings. But in
> the foreseeable future I don't need to do anything on the regulators
> (even though it might happen at some point). And since their setting is
> possibly non trivial, I'm not going to study them to write a complete
> bindings document and then make no use of it.
> 
> Is it a problem for you?

It's OK.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Best regards,
Krzysztof