linux-kernel - Re: [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2df4e64-a0aa-8da4-e279-2666e4d53d63@wolfvision.net>
Date:   Thu, 14 Oct 2021 12:11:34 +0200
From:   Michael Riesch <michael.riesch@...fvision.net>
To:     pgwipeout@...il.com
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy

Hi Peter,

> Good Afternoon,
> 
> This is my series to support the usb2 phy devices on the rk356x.
> The rk356x phy has a single muxed interrupt and has moved the usb2phy
> nodes out of the grf and into their own nodes.
> The phy needs to tie back into the grf for register control, similar to
> the rv1108.
> By moving the phys into their own nodes, they now have full
> #address_cells = 2 register addresses, but they still reside below the 32bit
> mmio range.
> 
> This driver series only supports the host configuration for the rk356x.
> I have have tested it on the following:
> rk3566 - Pine64 Quartz64 Model A
> rk3399 - Pine64 Rockpro64

On a RK3568 EVB1 with suitable additions to the board dts:
Tested-by: Michael Riesch <michael.riesch@...fvision.net>

Thanks for your efforts and best regards,
Michael

> 
> Please provide feedback and comments as you see fit.
> 
> Changelog:
> v2:
> - correct the order of the usb2phy-grf dt-bindings patch, thanks Johan
> - correct the conditional requirements of phy-rockchip-inno-usb2, thanks
>   Johan
> - drop increase generic-ohci clocks patch, thanks Heiko
> - correct rk356x.dtsi ordering
> - fix a dtbs-check callout
> 
> Peter Geis (8):
>   dt-bindings: soc: rockchip: add rk3568-usb2phy-grf
>   dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation
>   phy: phy-rockchip-inno-usb2: support #address_cells = 2
>   phy: phy-rockchip-inno-usb2: support standalone phy nodes
>   phy: phy-rockchip-inno-usb2: support muxed interrupts
>   phy: phy-rockchip-inno-usb2: add rk3568 support
>   arm64: dts: rockchip: add usb2 nodes to rk3568 device tree
>   arm64: dts: rockchip: add Quartz64-A usb2 support
> 
>  .../bindings/phy/phy-rockchip-inno-usb2.yaml  |  31 ++-
>  .../devicetree/bindings/soc/rockchip/grf.yaml |   1 +
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  52 ++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      |  98 +++++++
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 259 ++++++++++++++----
>  5 files changed, 383 insertions(+), 58 deletions(-)
> 
> -- 
> 2.25.1
>