linux-kernel - Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: Pass revision reg offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <125ed340-cec7-5f65-c4c1-ab5162b420f6@canonical.com>
Date:   Thu, 14 Oct 2021 14:05:45 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: Pass revision reg
 offsets

On 14/10/2021 14:03, Sam Protsenko wrote:
> On Thu, 14 Oct 2021 at 14:48, Krzysztof Kozlowski
> <krzysztof.kozlowski@...onical.com> wrote:
>>
>>>
>>>> Did you test it that it produces same result? Looks not - I gave it a
>>>> try and got wrong revision.
>>>>
>>>
>>> I only have Exynos850 based board, and that has 0x0 in Revision ID
>>> register. But for v3 I'll try to emulate register value in the code
>>> and make sure that the read value does not change with patch applied.
>>
>> You should get one of Odroid boards to test it. The MC1 is fairly cheap.
>>
> 
> Will do, I see how it can be useful for further work. For this series,
> I'm pretty sure I can test all cases by emulating the read register
> values. Would it be enough? Also, if you have some time, I'd ask you
> to check v3 on your board.

Yes, it's OK. I can test it.

Best regards,
Krzysztof