lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list] 
Message-ID: <a30d8839-0684-cbf8-8ece-639b69550959@linux.intel.com>
Date:   Thu, 14 Oct 2021 09:00:09 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     George Song <george.song@...imintegrated.com>, lgirdwood@...il.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
        srinivas.kandagatla@...aro.org, arnd@...db.de,
        alexandre.belloni@...tlin.com, jack.yu@...ltek.com,
        jiri.prchal@...ignal.cz, shumingf@...ltek.com,
        pbrobinson@...il.com, lars@...afoo.de, geert@...ux-m68k.org,
        hdegoede@...hat.com, paul@...pouillou.net,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Cc:     George Song <george.song@...log.com>
Subject: Re: [PATCH 2/2] ASoC: max98520: Add max98520 audio amplifier driver

quite a few alignment/style issues and more importantly your
Signed-off-by: tag mixes your two emails addresses.

scripts/checkpatch.pl --strict --codespell
0001-ASoC-max98520-Add-max98520-audio-amplifier-driver.patch
WARNING: Missing commit description - Add an appropriate one

WARNING: please write a paragraph that describes the config symbol fully
#32: FILE: sound/soc/codecs/Kconfig:941:
+config SND_SOC_MAX98520

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60:
new file mode 100644

CHECK: Alignment should match open parenthesis
#157: FILE: sound/soc/codecs/max98520.c:93:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2041_PCM_CLK_SETUP,

CHECK: Alignment should match open parenthesis
#180: FILE: sound/soc/codecs/max98520.c:116:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2040_PCM_MODE_CFG,

CHECK: Alignment should match open parenthesis
#204: FILE: sound/soc/codecs/max98520.c:140:
+static int max98520_set_clock(struct snd_soc_component *component,
+	struct snd_pcm_hw_params *params)

CHECK: Alignment should match open parenthesis
#222: FILE: sound/soc/codecs/max98520.c:158:
+		regmap_update_bits(max98520->regmap,
+							MAX98520_R2041_PCM_CLK_SETUP,

CHECK: Alignment should match open parenthesis
#231: FILE: sound/soc/codecs/max98520.c:167:
+static int max98520_dai_hw_params(struct snd_pcm_substream *substream,
+	struct snd_pcm_hw_params *params,

CHECK: Alignment should match open parenthesis
#260: FILE: sound/soc/codecs/max98520.c:196:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2040_PCM_MODE_CFG,

CHECK: Alignment should match open parenthesis
#317: FILE: sound/soc/codecs/max98520.c:253:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2042_PCM_SR_SETUP,

CHECK: Alignment should match open parenthesis
#328: FILE: sound/soc/codecs/max98520.c:264:
+static int max98520_dai_tdm_slot(struct snd_soc_dai *dai,
+	unsigned int tx_mask, unsigned int rx_mask,

CHECK: Alignment should match open parenthesis
#351: FILE: sound/soc/codecs/max98520.c:287:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2041_PCM_CLK_SETUP,

CHECK: Alignment should match open parenthesis
#373: FILE: sound/soc/codecs/max98520.c:309:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2040_PCM_MODE_CFG,

CHECK: Alignment should match open parenthesis
#378: FILE: sound/soc/codecs/max98520.c:314:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2044_PCM_RX_SRC2,

CHECK: Alignment should match open parenthesis
#382: FILE: sound/soc/codecs/max98520.c:318:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2044_PCM_RX_SRC2,

CHECK: Alignment should match open parenthesis
#401: FILE: sound/soc/codecs/max98520.c:337:
+static int max98520_dac_event(struct snd_soc_dapm_widget *w,
+	struct snd_kcontrol *kcontrol, int event)

CHECK: Please don't use multiple blank lines
#408: FILE: sound/soc/codecs/max98520.c:344:
+
+

CHECK: Alignment should match open parenthesis
#434: FILE: sound/soc/codecs/max98520.c:370:
+	SOC_ENUM_SINGLE(MAX98520_R2043_PCM_RX_SRC1,
+		0, 3, max98520_switch_text);

CHECK: Alignment should match open parenthesis
#441: FILE: sound/soc/codecs/max98520.c:377:
+	SND_SOC_DAPM_DAC_E("Amp Enable", "HiFi Playback",
+	MAX98520_R209F_AMP_EN, 0, 0, max98520_dac_event,

CHECK: Alignment should match open parenthesis
#539: FILE: sound/soc/codecs/max98520.c:475:
+SOC_SINGLE_TLV("Digital Volume", MAX98520_R2090_AMP_VOL_CTRL,
+	0, 0x7F, 1, max98520_digital_tlv),

CHECK: Alignment should match open parenthesis
#541: FILE: sound/soc/codecs/max98520.c:477:
+SOC_SINGLE_TLV("Speaker Volume", MAX98520_R2091_AMP_PATH_GAIN,
+	0, 0x5, 0, max98520_spk_tlv),

CHECK: Alignment should match open parenthesis
#544: FILE: sound/soc/codecs/max98520.c:480:
+SOC_SINGLE("Ramp Up Switch", MAX98520_R2092_AMP_DSP_CFG,
+	MAX98520_DSP_SPK_VOL_RMPUP_SHIFT, 1, 0),

CHECK: Alignment should match open parenthesis
#546: FILE: sound/soc/codecs/max98520.c:482:
+SOC_SINGLE("Ramp Down Switch", MAX98520_R2092_AMP_DSP_CFG,
+	MAX98520_DSP_SPK_VOL_RMPDN_SHIFT, 1, 0),

CHECK: Alignment should match open parenthesis
#574: FILE: sound/soc/codecs/max98520.c:510:
+SOC_SINGLE("DHT Limiter Mode", MAX98520_R20D2_LIMITER_CFG2,
+	MAX98520_DHT_LIMITER_MODE_SHIFT, 1, 0),

CHECK: Alignment should match open parenthesis
#576: FILE: sound/soc/codecs/max98520.c:512:
+SOC_SINGLE("DHT Hysteresis Switch", MAX98520_R20D6_DHT_HYSTERESIS_CFG,
+	MAX98520_DHT_HYSTERESIS_SWITCH_SHIFT, 1, 0),

CHECK: Alignment should match open parenthesis
#578: FILE: sound/soc/codecs/max98520.c:514:
+SOC_SINGLE_TLV("DHT Rot Pnt", MAX98520_R20D0_DHT_CFG1,
+	MAX98520_DHT_VROT_PNT_SHIFT, 10, 1, max98520_dht_rotation_point_tlv),

CHECK: Alignment should match open parenthesis
#580: FILE: sound/soc/codecs/max98520.c:516:
+SOC_SINGLE_TLV("DHT Supply Headroom", MAX98520_R20D1_LIMITER_CFG1,
+	MAX98520_DHT_SUPPLY_HR_SHIFT, 16, 0, max98520_dht_supply_hr_tlv),

CHECK: Alignment should match open parenthesis
#582: FILE: sound/soc/codecs/max98520.c:518:
+SOC_SINGLE_TLV("DHT Limiter Threshold", MAX98520_R20D2_LIMITER_CFG2,
+	MAX98520_DHT_LIMITER_THRESHOLD_SHIFT, 0xF, 1,
max98520_dht_lim_thresh_tlv),

CHECK: Alignment should match open parenthesis
#584: FILE: sound/soc/codecs/max98520.c:520:
+SOC_SINGLE_TLV("DHT Max Attenuation", MAX98520_R20D3_DHT_CFG2,
+	MAX98520_DHT_MAX_ATTEN_SHIFT, 20, 1, max98520_dht_max_atten_tlv),

CHECK: Alignment should match open parenthesis
#586: FILE: sound/soc/codecs/max98520.c:522:
+SOC_SINGLE_TLV("DHT Hysteresis", MAX98520_R20D6_DHT_HYSTERESIS_CFG,
+	MAX98520_DHT_HYSTERESIS_SHIFT, 0x7, 0, max98520_dht_hysteresis_tlv),

CHECK: Alignment should match open parenthesis
#592: FILE: sound/soc/codecs/max98520.c:528:
+SOC_SINGLE("ADC PVDD FLT Switch", MAX98520_R20B2_ADC_PVDD0_CFG,
+	MAX98520_FLT_EN_SHIFT, 1, 0),

CHECK: Alignment should match open parenthesis
#594: FILE: sound/soc/codecs/max98520.c:530:
+SOC_SINGLE("ADC TEMP FLT Switch", MAX98520_R20B3_ADC_THERMAL_CFG,
+	MAX98520_FLT_EN_SHIFT, 1, 0),

WARNING: line length of 106 exceeds 100 columns
#664: FILE: sound/soc/codecs/max98520.c:600:
+						MAX98520_R2092_AMP_DSP_CFG, MAX98520_SPK_SAFE_EN_MASK, 0);

CHECK: Alignment should match open parenthesis
#664: FILE: sound/soc/codecs/max98520.c:600:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R2092_AMP_DSP_CFG, MAX98520_SPK_SAFE_EN_MASK, 0);

CHECK: Alignment should match open parenthesis
#676: FILE: sound/soc/codecs/max98520.c:612:
+	regmap_update_bits(max98520->regmap,
+						MAX98520_R204F_PCM_RX_EN,

CHECK: Please use a blank line after function/struct/union/enum declarations
#691: FILE: sound/soc/codecs/max98520.c:627:
+}
+static int max98520_resume(struct device *dev)

CHECK: Alignment should match open parenthesis
#732: FILE: sound/soc/codecs/max98520.c:668:
+static int max98520_i2c_probe(struct i2c_client *i2c,
+	const struct i2c_device_id *id)

CHECK: Blank lines aren't necessary after an open brace '{'
#734: FILE: sound/soc/codecs/max98520.c:670:
+{
+

CHECK: Alignment should match open parenthesis
#741: FILE: sound/soc/codecs/max98520.c:677:
+	ret = i2c_check_functionality(adapter,
+		I2C_FUNC_SMBUS_BYTE

CHECK: Assignment operator '=' should be on the previous line
#758: FILE: sound/soc/codecs/max98520.c:694:
+	max98520->regmap
+		= devm_regmap_init_i2c(i2c, &max98520_regmap);

CHECK: Alignment should match open parenthesis
#783: FILE: sound/soc/codecs/max98520.c:719:
+	ret = regmap_read(max98520->regmap,
+		MAX98520_R21FF_REVISION_ID, &reg);

WARNING: DT compatible string "maxim,max98520" appears un-documented --
check ./Documentation/devicetree/bindings/
#810: FILE: sound/soc/codecs/max98520.c:746:
+	{ .compatible = "maxim,max98520", },

WARNING: From:/Signed-off-by: email address mismatch: 'From: George Song
<george.song@...imintegrated.com>' != 'Signed-off-by: George Song
<george.song@...log.com>'

total: 0 errors, 6 warnings, 37 checks, 967 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or
--fix-inplace.

0001-ASoC-max98520-Add-max98520-audio-amplifier-driver.patch has style
problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

On 10/13/21 2:52 AM, George Song wrote:

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ