linux-kernel - Re: [PATCH] iio: accel: kxcjk-1013: Fix possible memory leak in probe and remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 20:01:06 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        lars@...afoo.de, jic23@...nel.org, hdegoede@...hat.com,
        ddvlad@...il.com
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Fix possible memory leak in
 probe and remove

On Thu, Oct 14, 2021 at 09:38:52PM +0800, Yang Yingliang wrote:
> On 2021/10/14 22:54, Andy Shevchenko wrote:
> > On Thu, Oct 14, 2021 at 11:53:38AM +0800, Yang Yingliang wrote:
> > > When ACPI type is ACPI_SMO8500, the data->dready_trig will not be set, the
> > > memory allocated by iio_triggered_buffer_setup() will not be freed, and cause
> > > memory leak as follows:
> > It seems it's not first time I'm telling you to shrink the noise in the commit
> > message.  Can you please LEARN this once and forever?
> Thanks for you advice, I searched the whole kernel source tree commit
> message to
> learn how to make the memory leak report, I found most of them using the
> whole
> backtrace, so I make the report like they did in this patch.

Some maintainers do not care about bloated sizes of the commit messages,
however there are several advantages to have them shorter:

1/ saving resources (followed by disk storages and energy around the world,
   means being environment friendly for real);

2/ when reading log, noise make it much harder to understand, besides the
   fact that reading itself will be time consuming;

3/ nowadays some people are tending to read or even discuss the changes on
   the mobile devices, where screen size is not so big;

4/ the copied'n'pasted backtrace means that the contributor probably
   haven't thought through it and the quality of the change is in doubt.

> I will shrink
> the noise in v2.
> How about shrink it like this:

Much better!

-- 
With Best Regards,
Andy Shevchenko