linux-kernel - Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 07:25:27 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>,
        Denis Pauk <pauk.denis@...il.com>
Cc:     andy.shevchenko@...il.com, platform-driver-x86@...r.kernel.org,
        Tor Vic <torvic9@...lbox.org>,
        kernel test robot <lkp@...el.com>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus
 WMI.

On 10/14/21 5:08 AM, Eugene Shalygin wrote:
>> +struct asus_wmi_ec_sensor_address {
>> +       u8 index;
>> +       u8 bank;
>> +       u8 size;
>> +};
> The fourth field which you removed was supposed to hold the data
> encoding type, and together those four were packing nicely in u32...
> 

The compiler aligns the data nicely anyway (it will just leave
a 1-byte hole where needed), so the packing is really irrelevant.
Apart of that, does the above suggest that some information/
code is now missing from the driver ?

Guenter