linux-kernel - Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB95QAT44kyBR19cu6sP0kFJwFtVnmULqMzTQPArL94x2oxGkQ@mail.gmail.com>
Date:   Thu, 14 Oct 2021 16:36:54 +0200
From:   Eugene Shalygin <eugene.shalygin@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Denis Pauk <pauk.denis@...il.com>, andy.shevchenko@...il.com,
        platform-driver-x86@...r.kernel.org, Tor Vic <torvic9@...lbox.org>,
        kernel test robot <lkp@...el.com>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.

> The compiler aligns the data nicely anyway (it will just leave
> a 1-byte hole where needed), so the packing is really irrelevant.
> Apart of that, does the above suggest that some information/
> code is now missing from the driver ?

It is perhaps an unnecessary removal which will need to be undone
anyway when I (or others) add the south bridge voltage sensor.
Everything is OK with that change now, but since the size of the
address struct or union is 32 bits anyway, I would not remove that
field.

Eugene