linux-kernel - Re: [PATCH v10 07/11] x86/tdx: Add HLT support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWmYSSi6H/G+vXDd@google.com>
Date:   Fri, 15 Oct 2021 15:03:37 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Paolo Bonzini <pbonzini@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Juergen Gross <jgross@...e.com>, Deep Shah <sdeep@...are.com>,
        VMware Inc <pv-drivers@...are.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Peter H Anvin <hpa@...or.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 07/11] x86/tdx: Add HLT support for TDX guest

On Thu, Oct 14, 2021, Sathyanarayanan Kuppuswamy wrote:
> 
> On 10/14/21 2:30 AM, Thomas Gleixner wrote:
> > On Fri, Oct 08 2021 at 22:37, Kuppuswamy Sathyanarayanan wrote:
> > > +/* HLT TDVMCALL sub-function ID */
> > > +#define EXIT_REASON_HLT			12
> > arch/x86/include/uapi/asm/vmx.h:#define EXIT_REASON_HLT                 12
> > 
> > Is there a _good_ reason why this can't be reused?

So, no.  :-D

> As per current use case we can re-use it. Out of all TDX hypercall sub
> function IDs, only Instruction.PCONFIG (65) exit reason id is missing in
> vmx.h. But currently we are not handling it. So we can ignore it for now.

If the kernel proper needs EXIT_REASON_PCONFIG before KVM, just send a patch...