linux-kernel - Re: [PATCH v2 4/5] PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWjflHn2pVW4IRyM@rocinante>
Date:   Fri, 15 Oct 2021 03:55:32 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     kelvin.cao@...rochip.com
Cc:     kurt.schwemmer@...rosemi.com, logang@...tatee.com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kelvincao@...look.com,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v2 4/5] PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP

[+cc Jakub for visibility]

Hi,

> ENOTSUPP is not a SUSV4 error code, and the following checkpatch.pl
> warning will be given for new patches which still use ENOTSUPP.
> 
>     WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
> 
> See the link below for the discussion.
> 
>   https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/

This makes me wonder whether we should fix other occurrences of ENOTSUPP we
have in the PCI tree, as per:

  Index File                                       Line Content
      0 drivers/pci/msi.c                          1304 *  -ENOTSUPP otherwise
      1 drivers/pci/msi.c                          1316 return -ENOTSUPP;
      2 drivers/pci/pcie/dpc.c                      355 return -ENOTSUPP;
      3 drivers/pci/setup-res.c                     421 return -ENOTSUPP;
      4 drivers/pci/setup-res.c                     433 return -ENOTSUPP;
      5 drivers/pci/pci.c                          3600 * Returns -ENOTSUPP if resizable BARs are not supported at all.
      6 drivers/pci/pci.c                          3610 return -ENOTSUPP;
      7 drivers/pci/switch/switchtec.c              330 return -ENOTSUPP; \
      8 drivers/pci/switch/switchtec.c              616 return -ENOTSUPP;
      9 drivers/pci/switch/switchtec.c              824 return -ENOTSUPP;
     10 drivers/pci/switch/switchtec.c             1559 return -ENOTSUPP;
     11 drivers/pci/controller/dwc/pcie-tegra194.c 2244 return -ENOTSUPP;

What do you think Bjorn? Jakub?

	Krzysztof