linux-kernel - Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdpVwvOkjDWHcnWA-qZFm062UBp7VwdcpWbkdVR=i75Hw@mail.gmail.com>
Date:   Fri, 15 Oct 2021 22:52:45 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        linux-pci <linux-pci@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Alexander Duyck <alexanderduyck@...com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Borislav Petkov <bp@...en8.de>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Fiona Trahe <fiona.trahe@...el.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "H. Peter Anvin" <hpa@...or.com>, Ido Schimmel <idosch@...dia.com>,
        Ingo Molnar <mingo@...hat.com>, Jack Xu <jack.xu@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Jiri Olsa <jolsa@...hat.com>, Jiri Pirko <jiri@...dia.com>,
        Juergen Gross <jgross@...e.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Marco Chiappero <marco.chiappero@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Michael Buesch <m@...s.ch>,
        Michael Ellerman <mpe@...erman.id.au>,
        Namhyung Kim <namhyung@...nel.org>,
        "Oliver O'Halloran" <oohall@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Rafał Miłecki <zajec5@...il.com>,
        Russell Currey <ruscur@...sell.cc>,
        Salil Mehta <salil.mehta@...wei.com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Simon Horman <simon.horman@...igine.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        Taras Chornyi <tchornyi@...vell.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tomaszx Kowalik <tomaszx.kowalik@...el.com>,
        Vadym Kochan <vkochan@...vell.com>,
        Wojciech Ziemba <wojciech.ziemba@...el.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        linux-crypto <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org,
        "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" 
        <linuxppc-dev@...ts.ozlabs.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        USB <linux-usb@...r.kernel.org>,
        "open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
        MPT-FusionLinux.pdl@...adcom.com, netdev <netdev@...r.kernel.org>,
        oss-drivers@...igine.com, qat-linux@...el.com,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver

On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:

...

> so compared to Uwe's v6, I restored that section to the original code.
> My goal here was to make the patch as simple and easy to review as
> possible.

Thanks for elaboration. I have got it.

...

> You're right, this didn't make much sense in that patch.  I moved the
> line join to the previous patch, which unindented this section and
> made space for this to fit on one line.  Here's the revised commit:
>
>   https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=34ab316d7287

Side remark: default without break or return is error prone (okay, to
some extent). Perhaps adding the return statement there will make
things robust and clean.

-- 
With Best Regards,
Andy Shevchenko