linux-kernel - Re: (subset) [PATCH] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163431847249.251657.11309404044031278395.b4-ty@linaro.org>
Date:   Fri, 15 Oct 2021 12:22:13 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     mathieu.poirier@...aro.org, james.quinlan@...adcom.com,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        ohad@...ery.com
Cc:     kernel-janitors@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: (subset) [PATCH] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle_vdev()'

On Sat, 4 Sep 2021 13:37:32 +0200, Christophe JAILLET wrote:
> If 'copy_dma_range_map() fails, the memory allocated for 'rvdev' will leak.
> Move the 'copy_dma_range_map()' call after the device registration so
> that 'rproc_rvdev_release()' can be called to free some resources.
> 
> Also, branch to the error handling path if 'copy_dma_range_map()' instead
> of a direct return to avoid some other leaks.
> 
> [...]

Applied, thanks!

[1/1] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle_vdev()'
      commit: 0374a4ea7269645c46c3eb288526ea072fa19e79

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@...aro.org>