linux-kernel - Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWm+VUQmSbLB5yZn@equinox>
Date:   Fri, 15 Oct 2021 18:45:57 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Larry.Finger@...inger.net, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging: r8188eu: remove MSG_88E calls from
 hal/usb_halinit.c

On Fri, Oct 15, 2021 at 09:55:21AM +0200, Michael Straube wrote:
> On 10/15/21 02:02, Phillip Potter wrote:
> > Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> > no purpose other than to print the name of the function they are in
> > (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> > function, which is better accomplished by other means. Also remove
> > the jiffies assignment at the start of the function, as it is no
> > longer used.
> > 
> > Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> > ---
> >   drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> > index f6db5b05e6e7..abbd107ad3c1 100644
> > --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> > @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
> >   static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> >   {
> > -	u32 start = jiffies;
> > -
> > -	MSG_88E("====> %s\n", __func__);
> > -
> >   	_ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> >   	_ReadPROMContent(Adapter);
> > -	MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> > -
> >   	return _SUCCESS;
> >   }
> > 
> 
> Looks good to me.
> 
> Acked-by: Michael Straube <straube.linux@...il.com>
> 
> Thanks,
> Michael

Dear Michael,

Thanks for this, much appreciated.

Regards,
Phil