linux-kernel - Re: [PATCH] efi: select CRYPTO for EFI_EMBEDDED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YWnSDFPOx0U6iziT@gmail.com>
Date:   Fri, 15 Oct 2021 12:10:04 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     Vegard Nossum <vegard.nossum@...cle.com>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH] efi: select CRYPTO for EFI_EMBEDDED_FIRMWARE

On Fri, Oct 15, 2021 at 03:55:01PM +0200, Ard Biesheuvel wrote:
> (+ crypto folks)
> 
> On Fri, 15 Oct 2021 at 15:24, Vegard Nossum <vegard.nossum@...cle.com> wrote:
> >
> > Fix the following build warning:
> >
> >   WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
> >     Depends on [n]: CRYPTO [=n]
> >     Selected by [y]:
> >     - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
> >
> > Fixes: f0df68d5bae88 ("efi: Add embedded peripheral firmware support")
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
> 
> Hello Vegard,
> 
> I don't think this is the right fix, to be honest. The crypto library
> functions have no dependencies at all on the crypto API, so I think it
> would be better to do something like the below:

Actually some of the crypto library functions need __crypto_xor() and
__crypto_memneq() which are only compiled when CRYPTO.  So that will need to be
fixed by moving those functions to an appropriate place first.

- Eric