lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Oct 2021 21:27:50 +0200
From:   Hans de Goede <>
To:     Mark Brown <>
Cc:     "Rafael J . Wysocki" <>,
        Mark Gross <>,
        Andy Shevchenko <>,
        Daniel Scally <>,
        Laurent Pinchart <>,
        Mauro Carvalho Chehab <>,
        Liam Girdwood <>,
        Michael Turquette <>,
        Stephen Boyd <>, Len Brown <>,,,,
        Sakari Ailus <>,
        Kate Hsuan <>,,
Subject: Re: [PATCH 05/12] regulator: Introduce tps68470-regulator driver


On 10/15/21 8:58 PM, Mark Brown wrote:
> On Fri, Oct 15, 2021 at 08:50:13PM +0200, Hans de Goede wrote:
>> Are you happy with the platform_data for this driver as defined in
>> patch 4/12 ? :
> Some of the other review comments lead me to believe that you'd be
> sending out a new version at some point?

That is correct.

> I am very confused about why it's in the driver without a DMI quirk
> and/or clear comments about why and saying that this is a terrible
> example to copy.

The DMI quirks live in the ACPI glue code under drivers/platform/x86,
that code instantiates the MFD cell and sets the platform-data
as part of the cell.

> I'd also expect to get compile test coverage for the driver.

Ack, Stephen made the same remark for the clk driver. I'll fix
this for the next version.



Powered by blists - more mailing lists