linux-kernel - Re: [PATCH 2/2] watchdog: Add Realtek Otto watchdog timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <658d4e585fb9d8d295ebb56e7c944a784b9104a8.camel@svanheule.net>
Date:   Fri, 15 Oct 2021 21:15:35 +0100
From:   Sander Vanheule <sander@...nheule.net>
To:     kernel test robot <lkp@...el.com>, linux-watchdog@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] watchdog: Add Realtek Otto watchdog timer

On Fri, 2021-10-15 at 00:44 +0800, kernel test robot wrote:
> Hi Sander,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.15-rc5 next-20211013]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:   
> https://github.com/0day-ci/linux/commits/Sander-Vanheule/Add-Realtek-Otto-WDT-support/20211013-213511
> base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f4d0cc426f77df68
> 90aa868f96c2de89686aae8a
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         #
> https://github.com/0day-ci/linux/commit/32b957f54703ffbffecc825fb8df3106b2aab6b5
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Sander-Vanheule/Add-Realtek-Otto-WDT-
> support/20211013-213511
>         git checkout 32b957f54703ffbffecc825fb8df3106b2aab6b5
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
> ARCH=sh SHELL=/bin/bash drivers/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
> > > drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
>      855 | void clk_unprepare(struct clk *clk)
>          |      ^~~~~~~~~~~~~
>    In file included from drivers/clk/clk.c:9:
>    include/linux/clk.h:303:20: note: previous definition of 'clk_unprepare' with
> type 'void(struct clk *)'
>      303 | static inline void clk_unprepare(struct clk *clk)
>          |                    ^~~~~~~~~~~~~
> > > drivers/clk/clk.c:936:5: error: redefinition of 'clk_prepare'
>      936 | int clk_prepare(struct clk *clk)
>          |     ^~~~~~~~~~~
>    In file included from drivers/clk/clk.c:9:
>    include/linux/clk.h:271:19: note: previous definition of 'clk_prepare' with type
> 'int(struct clk *)'
>      271 | static inline int clk_prepare(struct clk *clk)
>          |                   ^~~~~~~~~~~
> > > drivers/clk/clk.c:1182:6: error: redefinition of 'clk_is_enabled_when_prepared'
>     1182 | bool clk_is_enabled_when_prepared(struct clk *clk)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    In file included from drivers/clk/clk.c:9:
>    include/linux/clk.h:284:20: note: previous definition of
> 'clk_is_enabled_when_prepared' with type 'bool(struct clk *)' {aka '_Bool(struct
> clk *)'}
>      284 | static inline bool clk_is_enabled_when_prepared(struct clk *clk)
>          |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for COMMON_CLK
>    Depends on !HAVE_LEGACY_CLK
>    Selected by
>    - REALTEK_OTTO_WDT && WATCHDOG && (MACH_REALTEK_RTL || COMPILE_TEST

I had used "select COMMON_CLK" in Kconfig, where other drivers use "depends on
COMMON_CLK". I've changed this to the latter now.

Since the tested config has both HAVE_LEGACY_CLK and COMMON_CLK set, I don't think
it's using a valid config anyway. After changing to "depends on COMMON_CLK", the
make.cross command listed above appears to build without problems.

Best,
Sander