lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 16 Oct 2021 05:24:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Felix Fietkau <nbd@....name>
Subject: [nbd168-wireless:mt76 73/113]
 drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1347:21: warning: variable
 'dev' set but not used

tree:   https://github.com/nbd168/wireless mt76
head:   39e333d657f49619c65b9f5b59aa6405f13abf35
commit: 6fab4ab4b0c10198055f44b4c6ac2c97a6b5d24e [73/113] mt76: mt7921: report tx rate directly from tx status
config: x86_64-randconfig-a004-20211015 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6069a6a5049497a32a50a49661c2f4169078bdba)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/nbd168/wireless/commit/6fab4ab4b0c10198055f44b4c6ac2c97a6b5d24e
        git remote add nbd168-wireless https://github.com/nbd168/wireless
        git fetch --no-tags nbd168-wireless mt76
        git checkout 6fab4ab4b0c10198055f44b4c6ac2c97a6b5d24e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1347:21: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
           struct mt7921_dev *dev;
                              ^
   1 warning generated.


vim +/dev +1347 drivers/net/wireless/mediatek/mt76/mt7921/mac.c

a7742ef4cd9166 Lorenzo Bianconi 2021-08-16  1344  
163f4d22c118d4 Sean Wang        2021-01-28  1345  void mt7921_tx_complete_skb(struct mt76_dev *mdev, struct mt76_queue_entry *e)
163f4d22c118d4 Sean Wang        2021-01-28  1346  {
163f4d22c118d4 Sean Wang        2021-01-28 @1347  	struct mt7921_dev *dev;
163f4d22c118d4 Sean Wang        2021-01-28  1348  
163f4d22c118d4 Sean Wang        2021-01-28  1349  	if (!e->txwi) {
163f4d22c118d4 Sean Wang        2021-01-28  1350  		dev_kfree_skb_any(e->skb);
163f4d22c118d4 Sean Wang        2021-01-28  1351  		return;
163f4d22c118d4 Sean Wang        2021-01-28  1352  	}
163f4d22c118d4 Sean Wang        2021-01-28  1353  
163f4d22c118d4 Sean Wang        2021-01-28  1354  	dev = container_of(mdev, struct mt7921_dev, mt76);
163f4d22c118d4 Sean Wang        2021-01-28  1355  
163f4d22c118d4 Sean Wang        2021-01-28  1356  	/* error path */
163f4d22c118d4 Sean Wang        2021-01-28  1357  	if (e->skb == DMA_DUMMY_DATA) {
163f4d22c118d4 Sean Wang        2021-01-28  1358  		struct mt76_txwi_cache *t;
163f4d22c118d4 Sean Wang        2021-01-28  1359  		struct mt7921_txp_common *txp;
163f4d22c118d4 Sean Wang        2021-01-28  1360  		u16 token;
163f4d22c118d4 Sean Wang        2021-01-28  1361  
163f4d22c118d4 Sean Wang        2021-01-28  1362  		txp = mt7921_txwi_to_txp(mdev, e->txwi);
163f4d22c118d4 Sean Wang        2021-01-28  1363  		token = le16_to_cpu(txp->hw.msdu_id[0]) & ~MT_MSDU_ID_VALID;
d089692bc7938a Lorenzo Bianconi 2021-04-20  1364  		t = mt76_token_put(mdev, token);
163f4d22c118d4 Sean Wang        2021-01-28  1365  		e->skb = t ? t->skb : NULL;
163f4d22c118d4 Sean Wang        2021-01-28  1366  	}
163f4d22c118d4 Sean Wang        2021-01-28  1367  
6fab4ab4b0c101 Lorenzo Bianconi 2021-09-04  1368  	if (e->skb)
6fab4ab4b0c101 Lorenzo Bianconi 2021-09-04  1369  		mt76_tx_complete_skb(mdev, e->wcid, e->skb);
163f4d22c118d4 Sean Wang        2021-01-28  1370  }
163f4d22c118d4 Sean Wang        2021-01-28  1371  

:::::: The code at line 1347 was first introduced by commit
:::::: 163f4d22c118d4eb9e275bf9ee1577c0d14b3208 mt76: mt7921: add MAC support

:::::: TO: Sean Wang <sean.wang@...iatek.com>
:::::: CC: Felix Fietkau <nbd@....name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35190 bytes)

Powered by blists - more mailing lists